another defensive check

Merge pull request #1009 from leethomason/leethomason/charref
Fix the potential overflow in char refs
2026-07-25 13:13:00 +04:00 · 2024-12-09 21:39:30 -08:00 · 2024-12-09 21:21:42 -08:00
1 changed files with 5 additions and 0 deletions
@@ -545,6 +545,11 @@ const char* XMLUtil::GetCharacterRef(const char* p, char* value, int* length)
        }
        // convert the UCS to UTF-8
        ConvertUTF32ToUTF8(ucs, value, length);
+		if (length == 0) {
+            // If length is 0, there was an error. (Security? Bad input?)
+            // Fail safely.
+			return 0;
+		}
        return p + delta + 1;
    }
    return p + 1;
Author	SHA1	Message	Date
Lee Thomason	1fadaae0c9	another defensive check	2024-12-09 21:39:30 -08:00
Lee Thomason	4cbb25155c	Merge pull request #1009 from leethomason/leethomason/charref Fix the potential overflow in char refs	2024-12-09 21:21:42 -08:00