potok/opencv
1
0
Fork 0
mirror of https://github.com/opencv/opencv.git synced 2026-07-31 00:03:03 +04:00
Code Packages Releases Wiki Activity

Merge pull request #27318 from Kumataro:fix27298

Browse Source 
core: add copyAt() for ROI operation #27318

Close https://github.com/opencv/opencv/issues/27320
Close https://github.com/opencv/opencv/issues/27298

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
This commit is contained in:
Kumataro
2025-11-17 16:58:20 +09:00
committed by GitHub
parent 6d52d416e8
commit 6f74546488
4 changed files with 117 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/core/test/test_mat.cpp
+65
View File
@@ -2713,4 +2713,69 @@ TEST(Mat, Recreate1DMatWithSameMeta)
EXPECT_NO_THROW(m.create(dims, depth));
}
// see https://github.com/opencv/opencv/issues/27298
TEST(Mat, copyAt_regression27298)
{
cv::Mat src(40/*height*/, 30/*width*/, CV_8UC1, Scalar(255));
// Normal
{
cv::Mat dst(100, 100, CV_8UC1, Scalar(0));
cv::Mat roi(dst, cv::Rect(0, 0, 30/*width*/, 40/*height*/));
void* roiData = roi.data;
EXPECT_NO_THROW(src.copyTo(roi));
EXPECT_EQ(roi.data, roiData);
EXPECT_EQ(countNonZero(roi), roi.size().width * roi.size().height) << roi;
}
{
cv::Mat dst(100, 100, CV_8UC1, Scalar(0));
cv::Mat roi(dst, cv::Rect(0, 0, 30/*width*/, 40/*height*/));
void* roiData = roi.data;
EXPECT_NO_THROW(src.copyAt(roi));
EXPECT_EQ(roi.data, roiData);
EXPECT_EQ(countNonZero(roi), roi.size().width * roi.size().height) << roi;
}
// Empty
{
cv::Mat roi; // empty
EXPECT_NO_THROW(src.copyTo(roi));
EXPECT_NE(roi.data, nullptr); // Allocated
EXPECT_EQ(countNonZero(roi), roi.size().width * roi.size().height) << roi;
}
{
cv::Mat roi; // empty
EXPECT_ANY_THROW(src.copyAt(roi));
}
// Different Type
{
cv::Mat dst(100, 100, CV_16UC1, Scalar(0));
cv::Mat roi(dst, cv::Rect(0, 0, 30/*width*/, 40/*height*/));
void* roiData = roi.data;
EXPECT_NO_THROW(src.copyTo(roi));
EXPECT_NE(roi.data, roiData); // Reallocated
EXPECT_EQ(countNonZero(roi), roi.size().width * roi.size().height) << roi;
}
{
cv::Mat dst(100, 100, CV_16UC1, Scalar(0));
cv::Mat roi(dst, cv::Rect(0, 0, 30/*width*/, 40/*height*/));
EXPECT_ANY_THROW(src.copyAt(roi));
}
// Different Size
{
cv::Mat dst(100, 100, CV_8UC1, Scalar(0));
cv::Mat roi(dst, cv::Rect(0, 0, 40/*width*/, 30/*height*/));
void* roiData = roi.data;
EXPECT_NO_THROW(src.copyTo(roi));
EXPECT_NE(roi.data, roiData); // Reallocated
EXPECT_EQ(countNonZero(roi), roi.size().width * roi.size().height) << roi;
}
{
cv::Mat dst(100, 100, CV_8UC1, Scalar(0));
cv::Mat roi(dst, cv::Rect(0, 0, 40/*width*/, 30/*height*/));
EXPECT_ANY_THROW(src.copyAt(roi));
}
}
}} // namespace