potok/tinyxml2
1
0
Fork 0
Code Pull Requests Packages Projects Releases Wiki Activity

Bools should really be implemented as self-closing <true /> and <false /> tags, not as 0/1 inside a tag, so removing those SetText variants again, in favor of SetBoolFirstChild() and BoolFirstChild() methods.

Browse Source
This commit is contained in:
Uli Kusterer
2014-01-21 02:23:20 +01:00
parent 7411c08e90
commit c1c20bb196
2 changed files with 28 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
tinyxml2.cpp
View File

@@ -1297,19 +1297,6 @@ void XMLElement::SetText( unsigned inNum )
}
void XMLElement::SetText( bool inBool )
{
char buf[BUF_SIZE];
XMLUtil::ToStr( inBool, buf, BUF_SIZE );
if ( FirstChild() && FirstChild()->ToText() )
FirstChild()->SetValue( buf );
else {
XMLText* theText = GetDocument()->NewText( buf );
InsertFirstChild( theText );
}
}
void XMLElement::SetText( double inNum )
{
char buf[BUF_SIZE];
@@ -1336,6 +1323,29 @@ void XMLElement::SetText( float inNum )
}
void XMLElement::SetBoolFirstChild( bool inBool )
{
if( FirstChild() && FirstChild()->ToElement()
&& (strcmp(FirstChild()->Value(),"true") == 0 || strcmp(FirstChild()->Value(),"false") == 0) ) {
FirstChild()->SetValue( inBool ? "true" : "false" );
}
else if( !FirstChild() ) {
XMLElement* theText = GetDocument()->NewElement( inBool ? "true" : "false" );
InsertFirstChild( theText );
}
}
bool XMLElement::BoolFirstChild()
{
if ( FirstChild() && FirstChild()->ToElement() ) {
return strcmp( FirstChild()->Value(), "true" ) == 0;
}
return false;
}
XMLError XMLElement::QueryIntText( int* ival ) const
{
if ( FirstChild() && FirstChild()->ToText() ) {