potok/tinyxml2
1
0
Fork 0
Code Pull Requests Packages Projects Releases Wiki Activity

Cleanup ErrorName() tests

Browse Source 
* clarify what is being tested to avoid duplicate lines in output
* prevent optimizations based on undefined behavior
This commit is contained in:
Dmitry-Me
2018-03-23 20:56:46 +03:00
parent 0741941589
commit 95f687b1f1
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
xmltest.cpp
View File

@@ -1984,8 +1984,14 @@ int main( int argc, const char ** argv )
for( int i = 0; i < XML_ERROR_COUNT; i++ ) { for( int i = 0; i < XML_ERROR_COUNT; i++ ) {
const XMLError error = static_cast<XMLError>(i); const XMLError error = static_cast<XMLError>(i);
const char* name = XMLDocument::ErrorIDToName(error); const char* name = XMLDocument::ErrorIDToName(error);
XMLTest( "ErrorName() after ClearError()", true, name != 0 ); XMLTest( "ErrorName() not null after ClearError()", true, name != 0 );
XMLTest( "ErrorName() after ClearError()", true, strlen(name) > 0 ); if( name == 0 ) {
// passing null pointer into strlen() is undefined behavior, so
// compiler is allowed to optimise away the null test above if it's
// as reachable as the strlen() call
continue;
}
XMLTest( "ErrorName() not empty after ClearError()", true, strlen(name) > 0 );
} }
} }