mirror of
https://github.com/opencv/opencv.git
synced 2026-07-24 21:03:03 +04:00
shubham khatri
498853d996
Fix JS bindings for namespaced Ptr factory return types #28143 This PR fixes an issue in the JS bindings generator for factory functions returning cv::Ptr<T> where T belongs to a namespaced class (for example cv::ximgproc::EdgeDrawing). The generator previously produced unqualified C++ template arguments such as: .constructor(select_overload<Ptr<EdgeDrawing>()>(&cv::ximgproc::createEdgeDrawing)) This results in invalid C++ because EdgeDrawing is not found in the global namespace. Fixes https://github.com/opencv/opencv/issues/28130 In modules/js/generator/embindgen.py, inside both: gen_function_binding_with_wrapper gen_function_binding a check is added: When factory == True, And the return type begins with Ptr<...>, And the inner type is missing a namespace (::), Ptr<T> → Ptr<class_info.cname> This ensures the fully-qualified class name (e.g. cv::ximgproc::EdgeDrawing) is used in the generated bindings. .constructor(select_overload<Ptr<cv::ximgproc::EdgeDrawing>()>(&cv::ximgproc::createEdgeDrawing)) Configured OpenCV with: cmake .. -DBUILD_opencv_js=ON Ran: make -j gen_opencv_js_source JS generator completed successfully without errors. This change does not modify generated files directly — it modifies the generator logic so the correct namespace is applied automatically.