From d6864cdd221cc03cd5f6e53625ee724b481cf28e Mon Sep 17 00:00:00 2001 From: Dmitry Kurtaev Date: Mon, 9 Jun 2025 09:23:04 +0300 Subject: [PATCH] Merge pull request #27418 from dkurt:fix_valgrind_warnings Fix valgrind warnings in tests #27418 ### Pull Request Readiness Checklist https://pullrequest.opencv.org/buildbot/builders/4_x_valgrind-lin64-debug/builds/100131/steps/test_calib3d/logs/valgrind%20summary https://pullrequest.opencv.org/buildbot/builders/4_x_valgrind-lin64-debug/builds/100131/steps/test_imgproc/logs/valgrind%20summary See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake --- modules/calib3d/test/test_solvepnp_ransac.cpp | 6 +++++- modules/imgproc/test/test_cornersubpix.cpp | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/modules/calib3d/test/test_solvepnp_ransac.cpp b/modules/calib3d/test/test_solvepnp_ransac.cpp index 5bd2a37ca1..b3a8c56e3f 100644 --- a/modules/calib3d/test/test_solvepnp_ransac.cpp +++ b/modules/calib3d/test/test_solvepnp_ransac.cpp @@ -344,7 +344,11 @@ protected: } } - solvePnPRansac(points, projectedPoints, intrinsics, distCoeffs, rvec, tvec, false, pointsCount, 0.5f, 0.99, inliers, method); + bool isEstimateSuccess = solvePnPRansac(points, projectedPoints, intrinsics, distCoeffs, rvec, tvec, false, pointsCount, 0.5f, 0.99, inliers, method); + if (!isEstimateSuccess) + { + return false; + } bool isTestSuccess = inliers.size() + numOutliers >= points.size(); diff --git a/modules/imgproc/test/test_cornersubpix.cpp b/modules/imgproc/test/test_cornersubpix.cpp index 5a2e633397..eebd76afea 100644 --- a/modules/imgproc/test/test_cornersubpix.cpp +++ b/modules/imgproc/test/test_cornersubpix.cpp @@ -69,6 +69,8 @@ TEST(Imgproc_CornerSubPix, out_of_image_corners) TEST(Imgproc_CornerSubPix, corners_on_the_edge) { cv::Mat image(500, 500, CV_8UC1); + RNG& rng = TS::ptr()->get_rng(); + cvtest::randUni(rng, image, 0, 255); cv::Size win(1, 1); cv::Size zeroZone(-1, -1); cv::TermCriteria criteria;