From 6fc0f38e1ca3593f55cc0f24c30f4069c62b35ce Mon Sep 17 00:00:00 2001 From: Kai Pastor Date: Sat, 6 Dec 2025 11:03:53 +0100 Subject: [PATCH] Fix CMake foreach loops --- cmake/OpenCVUtils.cmake | 2 +- modules/js/generator/CMakeLists.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cmake/OpenCVUtils.cmake b/cmake/OpenCVUtils.cmake index 5886f4f3cb..5ca7fab808 100644 --- a/cmake/OpenCVUtils.cmake +++ b/cmake/OpenCVUtils.cmake @@ -1667,7 +1667,7 @@ function(ocv_install_used_external_targets) if(NOT BUILD_SHARED_LIBS AND NOT (CMAKE_VERSION VERSION_LESS "3.13.0") # upgrade CMake: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/2152 ) - foreach(tgt in ${ARGN}) + foreach(tgt IN LISTS ARGN) if(tgt MATCHES "^ocv\.3rdparty\.") list(FIND __OPENCV_EXPORTED_EXTERNAL_TARGETS "${tgt}" _found) if(_found EQUAL -1) # don't export target twice diff --git a/modules/js/generator/CMakeLists.txt b/modules/js/generator/CMakeLists.txt index 48e3e2f92e..9fec48f950 100644 --- a/modules/js/generator/CMakeLists.txt +++ b/modules/js/generator/CMakeLists.txt @@ -50,7 +50,7 @@ if(DEFINED ENV{OPENCV_JS_WHITELIST}) else() #generate white list from modules//misc/js/whitelist.json set(OPENCV_JS_WHITELIST_FILE "${CMAKE_CURRENT_BINARY_DIR}/whitelist.json") - foreach(m in ${OPENCV_JS_MODULES}) + foreach(m IN LISTS OPENCV_JS_MODULES) set(js_whitelist "${OPENCV_MODULE_${m}_LOCATION}/misc/js/gen_dict.json") if (EXISTS "${js_whitelist}") file(READ "${js_whitelist}" whitelist_content)