From 6676c04d7cb2347a9257f9bd0341335e1f85452f Mon Sep 17 00:00:00 2001 From: gideok Kim Date: Mon, 2 Mar 2026 21:31:57 +0900 Subject: [PATCH] imgproc: remove redundant fabs() in fitEllipseDirect In fitEllipseDirect, `double det = fabs(cv::determinant(M))` applies fabs() unnecessarily since the next line `if (fabs(det) > 1.0e-10)` already takes the absolute value. Remove the outer fabs() to avoid the redundant operation. --- modules/imgproc/src/shapedescr.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/imgproc/src/shapedescr.cpp b/modules/imgproc/src/shapedescr.cpp index 8d78f00f26..a713cfeed4 100644 --- a/modules/imgproc/src/shapedescr.cpp +++ b/modules/imgproc/src/shapedescr.cpp @@ -750,7 +750,7 @@ cv::RotatedRect cv::fitEllipseDirect( InputArray _points ) M(2,1) = (DM(0,1) + (DM(0,3)*TM(0,1) + DM(0,4)*TM(1,1) + DM(0,5)*TM(2,1))/Ts)/2.; M(2,2) = (DM(0,2) + (DM(0,3)*TM(0,2) + DM(0,4)*TM(1,2) + DM(0,5)*TM(2,2))/Ts)/2.; - double det = fabs(cv::determinant(M)); + double det = cv::determinant(M); if (fabs(det) > 1.0e-10) break; eps = (float)(s/(n*2)*1e-2);