From 63048812c7a7bfdc4c73326dd1deafa84594db5b Mon Sep 17 00:00:00 2001 From: Dan Ben Yosef Date: Wed, 10 Mar 2021 13:00:17 -0500 Subject: [PATCH] Init params (StereoSGBMParams) in StereoSGBMImpl constructor initialization list To improve preformence it is better to init the params (StereoSGBMParams) in the initialization list. --- modules/calib3d/src/stereosgbm.cpp | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/modules/calib3d/src/stereosgbm.cpp b/modules/calib3d/src/stereosgbm.cpp index 7d5d23c18d..70eb3c658a 100644 --- a/modules/calib3d/src/stereosgbm.cpp +++ b/modules/calib3d/src/stereosgbm.cpp @@ -2186,19 +2186,21 @@ class StereoSGBMImpl CV_FINAL : public StereoSGBM { public: StereoSGBMImpl() + : params() { - params = StereoSGBMParams(); + // nothing } StereoSGBMImpl( int _minDisparity, int _numDisparities, int _SADWindowSize, int _P1, int _P2, int _disp12MaxDiff, int _preFilterCap, int _uniquenessRatio, int _speckleWindowSize, int _speckleRange, int _mode ) + : params(_minDisparity, _numDisparities, _SADWindowSize, + _P1, _P2, _disp12MaxDiff, _preFilterCap, + _uniquenessRatio, _speckleWindowSize, _speckleRange, + _mode) { - params = StereoSGBMParams( _minDisparity, _numDisparities, _SADWindowSize, - _P1, _P2, _disp12MaxDiff, _preFilterCap, - _uniquenessRatio, _speckleWindowSize, _speckleRange, - _mode ); + // nothing } void compute( InputArray leftarr, InputArray rightarr, OutputArray disparr ) CV_OVERRIDE