build: unreachable code after CV_Error()

2026-07-30 07:43:03 +04:00 · 2018-04-23 14:32:40 +03:00
parent 9615f8c994
commit 4cbec82ac1
15 changed files with 9 additions and 105 deletions
@@ -488,7 +488,6 @@ GpuMat& cv::cuda::GpuMat::setTo(Scalar s, Stream& _stream)
    (void) s;
    (void) _stream;
    throw_no_cuda();
-    return *this;
 }

 GpuMat& cv::cuda::GpuMat::setTo(Scalar s, InputArray _mask, Stream& _stream)
@@ -497,7 +496,6 @@ GpuMat& cv::cuda::GpuMat::setTo(Scalar s, InputArray _mask, Stream& _stream)
    (void) _mask;
    (void) _stream;
    throw_no_cuda();
-    return *this;
 }

 void cv::cuda::GpuMat::convertTo(OutputArray _dst, int rtype, Stream& _stream) const
@@ -138,7 +138,6 @@ MatAllocator* cv::cuda::HostMem::getAllocator(AllocType alloc_type)
 #ifndef HAVE_CUDA
    (void) alloc_type;
    throw_no_cuda();
-    return NULL;
 #else
    static std::map<unsigned int, Ptr<MatAllocator> > allocators;

@@ -302,7 +301,6 @@ GpuMat cv::cuda::HostMem::createGpuMatHeader() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return GpuMat();
 #else
    CV_Assert( alloc_type == SHARED );

@@ -79,7 +79,6 @@ int cv::cuda::getDevice()
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    int device;
    cudaSafeCall( cudaGetDevice(&device) );
@@ -101,7 +100,6 @@ bool cv::cuda::deviceSupports(FeatureSet feature_set)
 #ifndef HAVE_CUDA
    (void) feature_set;
    throw_no_cuda();
-    return false;
 #else
    static int versions[] =
    {
@@ -231,7 +229,6 @@ bool cv::cuda::TargetArchs::builtWith(cv::cuda::FeatureSet feature_set)
 #ifndef HAVE_CUDA
    (void) feature_set;
    throw_no_cuda();
-    return false;
 #else
    return cudaArch.builtWith(feature_set);
 #endif
@@ -243,7 +240,6 @@ bool cv::cuda::TargetArchs::hasPtx(int major, int minor)
    (void) major;
    (void) minor;
    throw_no_cuda();
-    return false;
 #else
    return cudaArch.hasPtx(major, minor);
 #endif
@@ -255,7 +251,6 @@ bool cv::cuda::TargetArchs::hasBin(int major, int minor)
    (void) major;
    (void) minor;
    throw_no_cuda();
-    return false;
 #else
    return cudaArch.hasBin(major, minor);
 #endif
@@ -267,7 +262,6 @@ bool cv::cuda::TargetArchs::hasEqualOrLessPtx(int major, int minor)
    (void) major;
    (void) minor;
    throw_no_cuda();
-    return false;
 #else
    return cudaArch.hasEqualOrLessPtx(major, minor);
 #endif
@@ -279,7 +273,6 @@ bool cv::cuda::TargetArchs::hasEqualOrGreaterPtx(int major, int minor)
    (void) major;
    (void) minor;
    throw_no_cuda();
-    return false;
 #else
    return cudaArch.hasEqualOrGreaterPtx(major, minor);
 #endif
@@ -291,7 +284,6 @@ bool cv::cuda::TargetArchs::hasEqualOrGreaterBin(int major, int minor)
    (void) major;
    (void) minor;
    throw_no_cuda();
-    return false;
 #else
    return cudaArch.hasEqualOrGreaterBin(major, minor);
 #endif
@@ -350,7 +342,6 @@ const char* cv::cuda::DeviceInfo::name() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return "";
 #else
    return deviceProps().get(device_id_)->name;
 #endif
@@ -360,7 +351,6 @@ size_t cv::cuda::DeviceInfo::totalGlobalMem() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->totalGlobalMem;
 #endif
@@ -370,7 +360,6 @@ size_t cv::cuda::DeviceInfo::sharedMemPerBlock() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->sharedMemPerBlock;
 #endif
@@ -380,7 +369,6 @@ int cv::cuda::DeviceInfo::regsPerBlock() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->regsPerBlock;
 #endif
@@ -390,7 +378,6 @@ int cv::cuda::DeviceInfo::warpSize() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->warpSize;
 #endif
@@ -400,7 +387,6 @@ size_t cv::cuda::DeviceInfo::memPitch() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->memPitch;
 #endif
@@ -410,7 +396,6 @@ int cv::cuda::DeviceInfo::maxThreadsPerBlock() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->maxThreadsPerBlock;
 #endif
@@ -420,7 +405,6 @@ Vec3i cv::cuda::DeviceInfo::maxThreadsDim() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return Vec3i();
 #else
    return Vec3i(deviceProps().get(device_id_)->maxThreadsDim);
 #endif
@@ -430,7 +414,6 @@ Vec3i cv::cuda::DeviceInfo::maxGridSize() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return Vec3i();
 #else
    return Vec3i(deviceProps().get(device_id_)->maxGridSize);
 #endif
@@ -440,7 +423,6 @@ int cv::cuda::DeviceInfo::clockRate() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->clockRate;
 #endif
@@ -450,7 +432,6 @@ size_t cv::cuda::DeviceInfo::totalConstMem() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->totalConstMem;
 #endif
@@ -460,7 +441,6 @@ int cv::cuda::DeviceInfo::majorVersion() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->major;
 #endif
@@ -470,7 +450,6 @@ int cv::cuda::DeviceInfo::minorVersion() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->minor;
 #endif
@@ -480,7 +459,6 @@ size_t cv::cuda::DeviceInfo::textureAlignment() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->textureAlignment;
 #endif
@@ -490,7 +468,6 @@ size_t cv::cuda::DeviceInfo::texturePitchAlignment() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->texturePitchAlignment;
 #endif
@@ -500,7 +477,6 @@ int cv::cuda::DeviceInfo::multiProcessorCount() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->multiProcessorCount;
 #endif
@@ -510,7 +486,6 @@ bool cv::cuda::DeviceInfo::kernelExecTimeoutEnabled() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return false;
 #else
    return deviceProps().get(device_id_)->kernelExecTimeoutEnabled != 0;
 #endif
@@ -520,7 +495,6 @@ bool cv::cuda::DeviceInfo::integrated() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return false;
 #else
    return deviceProps().get(device_id_)->integrated != 0;
 #endif
@@ -530,7 +504,6 @@ bool cv::cuda::DeviceInfo::canMapHostMemory() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return false;
 #else
    return deviceProps().get(device_id_)->canMapHostMemory != 0;
 #endif
@@ -540,7 +513,6 @@ DeviceInfo::ComputeMode cv::cuda::DeviceInfo::computeMode() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return ComputeModeDefault;
 #else
    static const ComputeMode tbl[] =
    {
@@ -558,7 +530,6 @@ int cv::cuda::DeviceInfo::maxTexture1D() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->maxTexture1D;
 #endif
@@ -568,7 +539,6 @@ int cv::cuda::DeviceInfo::maxTexture1DMipmap() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    #if CUDA_VERSION >= 5000
        return deviceProps().get(device_id_)->maxTexture1DMipmap;
@@ -583,7 +553,6 @@ int cv::cuda::DeviceInfo::maxTexture1DLinear() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->maxTexture1DLinear;
 #endif
@@ -593,7 +562,6 @@ Vec2i cv::cuda::DeviceInfo::maxTexture2D() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return Vec2i();
 #else
    return Vec2i(deviceProps().get(device_id_)->maxTexture2D);
 #endif
@@ -603,7 +571,6 @@ Vec2i cv::cuda::DeviceInfo::maxTexture2DMipmap() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return Vec2i();
 #else
    #if CUDA_VERSION >= 5000
        return Vec2i(deviceProps().get(device_id_)->maxTexture2DMipmap);
@@ -618,7 +585,6 @@ Vec3i cv::cuda::DeviceInfo::maxTexture2DLinear() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return Vec3i();
 #else
    return Vec3i(deviceProps().get(device_id_)->maxTexture2DLinear);
 #endif
@@ -628,7 +594,6 @@ Vec2i cv::cuda::DeviceInfo::maxTexture2DGather() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return Vec2i();
 #else
    return Vec2i(deviceProps().get(device_id_)->maxTexture2DGather);
 #endif
@@ -638,7 +603,6 @@ Vec3i cv::cuda::DeviceInfo::maxTexture3D() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return Vec3i();
 #else
    return Vec3i(deviceProps().get(device_id_)->maxTexture3D);
 #endif
@@ -648,7 +612,6 @@ int cv::cuda::DeviceInfo::maxTextureCubemap() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->maxTextureCubemap;
 #endif
@@ -658,7 +621,6 @@ Vec2i cv::cuda::DeviceInfo::maxTexture1DLayered() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return Vec2i();
 #else
    return Vec2i(deviceProps().get(device_id_)->maxTexture1DLayered);
 #endif
@@ -668,7 +630,6 @@ Vec3i cv::cuda::DeviceInfo::maxTexture2DLayered() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return Vec3i();
 #else
    return Vec3i(deviceProps().get(device_id_)->maxTexture2DLayered);
 #endif
@@ -678,7 +639,6 @@ Vec2i cv::cuda::DeviceInfo::maxTextureCubemapLayered() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return Vec2i();
 #else
    return Vec2i(deviceProps().get(device_id_)->maxTextureCubemapLayered);
 #endif
@@ -688,7 +648,6 @@ int cv::cuda::DeviceInfo::maxSurface1D() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->maxSurface1D;
 #endif
@@ -698,7 +657,6 @@ Vec2i cv::cuda::DeviceInfo::maxSurface2D() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return Vec2i();
 #else
    return Vec2i(deviceProps().get(device_id_)->maxSurface2D);
 #endif
@@ -708,7 +666,6 @@ Vec3i cv::cuda::DeviceInfo::maxSurface3D() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return Vec3i();
 #else
    return Vec3i(deviceProps().get(device_id_)->maxSurface3D);
 #endif
@@ -718,7 +675,6 @@ Vec2i cv::cuda::DeviceInfo::maxSurface1DLayered() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return Vec2i();
 #else
    return Vec2i(deviceProps().get(device_id_)->maxSurface1DLayered);
 #endif
@@ -728,7 +684,6 @@ Vec3i cv::cuda::DeviceInfo::maxSurface2DLayered() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return Vec3i();
 #else
    return Vec3i(deviceProps().get(device_id_)->maxSurface2DLayered);
 #endif
@@ -738,7 +693,6 @@ int cv::cuda::DeviceInfo::maxSurfaceCubemap() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->maxSurfaceCubemap;
 #endif
@@ -748,7 +702,6 @@ Vec2i cv::cuda::DeviceInfo::maxSurfaceCubemapLayered() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return Vec2i();
 #else
    return Vec2i(deviceProps().get(device_id_)->maxSurfaceCubemapLayered);
 #endif
@@ -758,7 +711,6 @@ size_t cv::cuda::DeviceInfo::surfaceAlignment() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->surfaceAlignment;
 #endif
@@ -768,7 +720,6 @@ bool cv::cuda::DeviceInfo::concurrentKernels() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return false;
 #else
    return deviceProps().get(device_id_)->concurrentKernels != 0;
 #endif
@@ -778,7 +729,6 @@ bool cv::cuda::DeviceInfo::ECCEnabled() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return false;
 #else
    return deviceProps().get(device_id_)->ECCEnabled != 0;
 #endif
@@ -788,7 +738,6 @@ int cv::cuda::DeviceInfo::pciBusID() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->pciBusID;
 #endif
@@ -798,7 +747,6 @@ int cv::cuda::DeviceInfo::pciDeviceID() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->pciDeviceID;
 #endif
@@ -808,7 +756,6 @@ int cv::cuda::DeviceInfo::pciDomainID() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->pciDomainID;
 #endif
@@ -818,7 +765,6 @@ bool cv::cuda::DeviceInfo::tccDriver() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return false;
 #else
    return deviceProps().get(device_id_)->tccDriver != 0;
 #endif
@@ -828,7 +774,6 @@ int cv::cuda::DeviceInfo::asyncEngineCount() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->asyncEngineCount;
 #endif
@@ -838,7 +783,6 @@ bool cv::cuda::DeviceInfo::unifiedAddressing() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return false;
 #else
    return deviceProps().get(device_id_)->unifiedAddressing != 0;
 #endif
@@ -848,7 +792,6 @@ int cv::cuda::DeviceInfo::memoryClockRate() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->memoryClockRate;
 #endif
@@ -858,7 +801,6 @@ int cv::cuda::DeviceInfo::memoryBusWidth() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->memoryBusWidth;
 #endif
@@ -868,7 +810,6 @@ int cv::cuda::DeviceInfo::l2CacheSize() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->l2CacheSize;
 #endif
@@ -878,7 +819,6 @@ int cv::cuda::DeviceInfo::maxThreadsPerMultiProcessor() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return 0;
 #else
    return deviceProps().get(device_id_)->maxThreadsPerMultiProcessor;
 #endif
@@ -906,7 +846,6 @@ bool cv::cuda::DeviceInfo::isCompatible() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return false;
 #else
    // Check PTX compatibility
    if (TargetArchs::hasEqualOrLessPtx(majorVersion(), minorVersion()))
@@ -450,7 +450,6 @@ bool cv::cuda::Stream::queryIfComplete() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return false;
 #else
    cudaError_t err = cudaStreamQuery(impl_->stream);

@@ -526,8 +525,6 @@ Stream& cv::cuda::Stream::Null()
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    static Stream stream;
-    return stream;
 #else
    const int deviceId = getDevice();
    return initializer.getNullStream(deviceId);
@@ -716,7 +713,6 @@ GpuMat cv::cuda::BufferPool::getBuffer(int rows, int cols, int type)
    (void) cols;
    (void) type;
    throw_no_cuda();
-    return GpuMat();
 #else
    GpuMat buf(allocator_);
    buf.create(rows, cols, type);
@@ -806,7 +802,6 @@ bool cv::cuda::Event::queryIfComplete() const
 {
 #ifndef HAVE_CUDA
    throw_no_cuda();
-    return false;
 #else
    cudaError_t err = cudaEventQuery(impl_->event);

@@ -833,7 +828,6 @@ float cv::cuda::Event::elapsedTime(const Event& start, const Event& end)
    (void) start;
    (void) end;
    throw_no_cuda();
-    return 0.0f;
 #else
    float ms;
    cudaSafeCall( cudaEventElapsedTime(&ms, start.impl_->event, end.impl_->event) );
@@ -146,7 +146,6 @@
    static void* IntGetProcAddress(const char*)
    {
        CV_Error(cv::Error::OpenGlNotSupported, "The library is compiled without OpenGL support");
-        return 0;
    }
 #endif

@@ -57,7 +57,7 @@ using namespace cv::cuda;
 namespace
 {
 #ifndef HAVE_OPENGL
-inline static void throw_no_ogl() { CV_Error(cv::Error::OpenGlNotSupported, "The library is compiled without OpenGL support"); }
+inline static CV_NORETURN void throw_no_ogl() { CV_Error(cv::Error::OpenGlNotSupported, "The library is compiled without OpenGL support"); }
 #elif defined _DEBUG
 inline static bool checkError(const char* file, const int line, const char* func = 0)
 {
@@ -82,8 +82,7 @@ inline static bool checkError(const char* file, const int line, const char* func
        default:
            msg = "Unknown error";
        };
-        cvError(CV_OpenGlApiCallError, func, msg, file, line);
-        return false;
+        cv::errorNoReturn(Error::OpenGlApiCallError, func, msg, file, line);
    }
    return true;
 }
@@ -697,7 +696,6 @@ cv::ogl::Buffer cv::ogl::Buffer::clone(Target target, bool autoRelease) const
    (void) target;
    (void) autoRelease;
    throw_no_ogl();
-    return cv::ogl::Buffer();
 #else
    ogl::Buffer buf;
    buf.copyFrom(*this, target, autoRelease);
@@ -731,7 +729,6 @@ Mat cv::ogl::Buffer::mapHost(Access access)
 #ifndef HAVE_OPENGL
    (void) access;
    throw_no_ogl();
-    return Mat();
 #else
    return Mat(rows_, cols_, type_, impl_->mapHost(access));
 #endif
@@ -750,11 +747,9 @@ GpuMat cv::ogl::Buffer::mapDevice()
 {
 #ifndef HAVE_OPENGL
    throw_no_ogl();
-    return GpuMat();
 #else
    #ifndef HAVE_CUDA
        throw_no_cuda();
-        return GpuMat();
    #else
        return GpuMat(rows_, cols_, type_, impl_->mapDevice());
    #endif
@@ -779,12 +774,10 @@ cuda::GpuMat cv::ogl::Buffer::mapDevice(cuda::Stream& stream)
 #ifndef HAVE_OPENGL
    (void) stream;
    throw_no_ogl();
-    return GpuMat();
 #else
    #ifndef HAVE_CUDA
        (void) stream;
        throw_no_cuda();
-        return GpuMat();
    #else
        return GpuMat(rows_, cols_, type_, impl_->mapDevice(cuda::StreamAccessor::getStream(stream)));
    #endif
@@ -810,7 +803,6 @@ unsigned int cv::ogl::Buffer::bufId() const
 {
 #ifndef HAVE_OPENGL
    throw_no_ogl();
-    return 0;
 #else
    return impl_->bufId();
 #endif
@@ -1216,7 +1208,6 @@ unsigned int cv::ogl::Texture2D::texId() const
 {
 #ifndef HAVE_OPENGL
    throw_no_ogl();
-    return 0;
 #else
    return impl_->texId();
 #endif