From 1a15596f21211dd24c9ea2a49539b1742552bd1f Mon Sep 17 00:00:00 2001 From: Maksim Shabunin Date: Wed, 21 Jan 2015 12:53:50 +0300 Subject: [PATCH 1/2] Fixed build warning in GDAL support module --- modules/imgcodecs/src/grfmt_gdal.cpp | 29 ---------------------------- 1 file changed, 29 deletions(-) diff --git a/modules/imgcodecs/src/grfmt_gdal.cpp b/modules/imgcodecs/src/grfmt_gdal.cpp index 0311630950..55dd7192f6 100644 --- a/modules/imgcodecs/src/grfmt_gdal.cpp +++ b/modules/imgcodecs/src/grfmt_gdal.cpp @@ -140,35 +140,6 @@ int gdal2opencv( const GDALDataType& gdalType, const int& channels ){ return -1; } - -std::string GetOpenCVTypeName( const int& type ){ - - switch(type){ - case CV_8UC1: - return "CV_8UC1"; - case CV_8UC3: - return "CV_8UC3"; - case CV_8UC4: - return "CV_8UC4"; - case CV_16UC1: - return "CV_16UC1"; - case CV_16UC3: - return "CV_16UC3"; - case CV_16UC4: - return "CV_16UC4"; - case CV_16SC1: - return "CV_16SC1"; - case CV_16SC3: - return "CV_16SC3"; - case CV_16SC4: - return "CV_16SC4"; - default: - return "Unknown"; - } - return "Unknown"; -} - - /** * GDAL Decoder Constructor */ From 036b13ee05c793a765d621aa785b078fcf08fe03 Mon Sep 17 00:00:00 2001 From: Maksim Shabunin Date: Wed, 21 Jan 2015 14:01:21 +0300 Subject: [PATCH 2/2] Fixed GDAL loader check --- modules/imgcodecs/src/loadsave.cpp | 10 +++++----- modules/imgcodecs/test/test_grfmt.cpp | 5 +++-- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/modules/imgcodecs/src/loadsave.cpp b/modules/imgcodecs/src/loadsave.cpp index c06b42aded..8526a4a3f0 100644 --- a/modules/imgcodecs/src/loadsave.cpp +++ b/modules/imgcodecs/src/loadsave.cpp @@ -247,7 +247,7 @@ imread_( const String& filename, int flags, int hdrtype, Mat* mat=0 ) ImageDecoder decoder; #ifdef HAVE_GDAL - if( (flags & IMREAD_LOAD_GDAL) == IMREAD_LOAD_GDAL ){ + if(flags != IMREAD_UNCHANGED && (flags & IMREAD_LOAD_GDAL) == IMREAD_LOAD_GDAL ){ decoder = GdalDecoder().newDecoder(); }else{ #endif @@ -275,7 +275,7 @@ imread_( const String& filename, int flags, int hdrtype, Mat* mat=0 ) // grab the decoded type int type = decoder->type(); - if( flags != -1 ) + if( flags != IMREAD_UNCHANGED ) { if( (flags & CV_LOAD_IMAGE_ANYDEPTH) == 0 ) type = CV_MAKETYPE(CV_8U, CV_MAT_CN(type)); @@ -336,7 +336,7 @@ imreadmulti_(const String& filename, int flags, std::vector& mats) ImageDecoder decoder; #ifdef HAVE_GDAL - if ((flags & IMREAD_LOAD_GDAL) == IMREAD_LOAD_GDAL){ + if (flags != IMREAD_UNCHANGED && (flags & IMREAD_LOAD_GDAL) == IMREAD_LOAD_GDAL){ decoder = GdalDecoder().newDecoder(); } else{ @@ -362,7 +362,7 @@ imreadmulti_(const String& filename, int flags, std::vector& mats) { // grab the decoded type int type = decoder->type(); - if (flags != -1) + if (flags != IMREAD_UNCHANGED) { if ((flags & CV_LOAD_IMAGE_ANYDEPTH) == 0) type = CV_MAKETYPE(CV_8U, CV_MAT_CN(type)); @@ -508,7 +508,7 @@ imdecode_( const Mat& buf, int flags, int hdrtype, Mat* mat=0 ) size.height = decoder->height(); int type = decoder->type(); - if( flags != -1 ) + if( flags != IMREAD_UNCHANGED ) { if( (flags & CV_LOAD_IMAGE_ANYDEPTH) == 0 ) type = CV_MAKETYPE(CV_8U, CV_MAT_CN(type)); diff --git a/modules/imgcodecs/test/test_grfmt.cpp b/modules/imgcodecs/test/test_grfmt.cpp index d1610ae7fc..423d030a0c 100644 --- a/modules/imgcodecs/test/test_grfmt.cpp +++ b/modules/imgcodecs/test/test_grfmt.cpp @@ -104,7 +104,8 @@ TEST(Imgcodecs_imread, regression) ASSERT_TRUE(imread_compare(folder + string(filenames[i]), IMREAD_COLOR)); ASSERT_TRUE(imread_compare(folder + string(filenames[i]), IMREAD_ANYDEPTH)); ASSERT_TRUE(imread_compare(folder + string(filenames[i]), IMREAD_ANYCOLOR)); - ASSERT_TRUE(imread_compare(folder + string(filenames[i]), IMREAD_LOAD_GDAL)); + if (i != 2) // GDAL does not support hdr + ASSERT_TRUE(imread_compare(folder + string(filenames[i]), IMREAD_LOAD_GDAL)); } } @@ -684,7 +685,7 @@ public: compare(IMREAD_COLOR); compare(IMREAD_ANYDEPTH); compare(IMREAD_ANYCOLOR); - compare(IMREAD_LOAD_GDAL); + // compare(IMREAD_LOAD_GDAL); // GDAL does not support multi-page TIFFs } };