potok/json
1
0
Fork 0
mirror of https://github.com/nlohmann/json.git synced 2026-07-21 19:23:03 +04:00
Code Packages Releases Wiki Activity

Fix -Wunneeded-internal-declaration for CustomSentinel in test

Browse Source 
CustomSentinel lives in an anonymous namespace (internal linkage), and
the library's parse loop only ever evaluates the iterator-first
direction (it != last), so the reversed-order friend operator!= was
never referenced. Clang's -Weverything flags such unused internal
declarations as an error. Drop the unused overload; the used direction
is enough to satisfy can_compare_ne's either-order detection.

Signed-off-by: Niels Lohmann <mail@nlohmann.me>
This commit is contained in:
Niels Lohmann
2026-07-10 23:25:21 +02:00
parent 146e5e0bc7
commit da95d1184e
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/src/unit-user_defined_input.cpp
+3 -6
View File
@@ -173,16 +173,13 @@ struct CustomSentinel
{ {
const char* end_ptr; const char* end_ptr;
// Support both directions for != comparison // only the iterator-first direction (it != sentinel) is ever evaluated by
// the library's parse loop; a reversed-order overload would go unused and
// trip -Wunneeded-internal-declaration under -Weverything
friend bool operator!=(const char* it, const CustomSentinel& sentinel) friend bool operator!=(const char* it, const CustomSentinel& sentinel)
{ {
return it != sentinel.end_ptr; return it != sentinel.end_ptr;
} }
friend bool operator!=(const CustomSentinel& sentinel, const char* it)
{
return it != sentinel.end_ptr;
}
}; };
TEST_CASE("Parse with heterogeneous iterator and sentinel types") TEST_CASE("Parse with heterogeneous iterator and sentinel types")